Re: [perl #41975] Makefile is missing dependencies on lib/Parrot/Pmc2c/PMETHODs.pm

[chromatic]

On Friday 27 April 2007 12:33, jerry gay wrote:

> On 4/27/07, chromatic <[EMAIL PROTECTED]> wrote:

> > If the inter-PMC dependencies are okay, it looks like we need to set the
> > dependencies appropriately on:
> >
> > $ grep -l PCCMETHOD src/pmc/*.pmc
> > src/pmc/class.pmc
> > src/pmc/exporter.pmc
> > src/pmc/namespace.pmc
> > src/pmc/pccmethod_test.pmc
> > src/pmc/role.pmc
> > src/pmc/smop_attribute.pmc
> > src/pmc/smop_class.pmc
> >
> > Is it worth having a test to see if every PMC with a PCCMETHOD marks the
> > dependency appropriately?
>
> yes! you certainly can't rely us to mark the dependencies on our own,
> given that long list of pmc's.

Here's the barest test file I could make that seems to do the trick.

-- c


#! perl
# Copyright (C) 2007, The Perl Foundation.
# $Id$

use strict;
use warnings;

use File::Glob;
use File::Spec;

use Test::More;

my $pmc_dir  = File::Spec->catfile( qw( src pmc *.pmc ) );
my @pmcs     = grep { contains_pccmethod( $_ ) } glob( $pmc_dir );
my $find_pmc = join( '|', map { s/\.pmc/\.dump/; $_ } @pmcs );
my $find_rx  = qr/^($find_pmc) : /;

open( my $fh, '<', 'Makefile' ) or die "Can't read Makefile: $!\n";

plan( tests => scalar @pmcs );

while (<$fh>)
{
    next unless /$find_rx/;
    my ($file) = $1;

    my $has_dep = 0;

    while (<$fh>)
    {
        last unless /\S/;
        next unless /PCCMETHOD\.pm/;
        $has_dep = 1;
        last;
    }
    ok( $has_dep, "$file should mark PCCMETHOD.pm dependency" );
}

sub contains_pccmethod
{
    my $file = shift;
    open( my $fh, '<', $file ) or die "Can't read '$file': $!\n";

    local $_;
    while (<$fh>)
    {
        next unless /PCCMETHOD/;
        return 1;
    }

    return;
}