> On 20 Dec 2015, at 23:18, Zefram <zef...@fysh.org> wrote: > > Elizabeth Mattijsen via RT wrote: >> Fixed with ae8d9809c432f071643384 > > It's good that you're now factoring out the escaping code. This means > that these methods (including for IO::Path) are now correct. But the > factoring is still flawed, in that you've inlined what remains of > the body of Str.perl into each of these .perl methods. This inlining > doesn't achieve anything; it would be much more sensible for them to > call .perl on their Str values.
Good point. Followed your suggestion in 8ddfff5533d4d77dbd7da65 . > In the case of IO::Path you also have > some gratuitous escaping of pipe characters, a relic of former versions > of the code that used that as the delimiter. Another good point, fixed in 8245d9072177f26251f128 >> Zefram: I assume you checked all .perl methods in core for this, or >> should I look at them some more? > I looked systematically through rakudo/src, and the ones I mentioned > are all that I found. Thank you! Liz
