On 2/18/2014 16:15, Nicholas Clark wrote:
On Tue, Feb 18, 2014 at 03:11:01PM +0000, Nicholas Clark wrote:
Attached is the proposed patch, which implements compiler based probing for
the MoarVM Configure.pl. Tested on OS X, FreeBSD, Linux, HP/UX and AIX.
Not tested on Win32, so might not work there without tweaks.
Attached are 5 patches which build on the probing patch, to create a
MVM_STATIC_INLINE macro, and then use it to inline various functions from
sc.c, and convert 2 macros in sc.h to inline functions.
Thanks for these. Applied all 6 patches. Then added a 7th of my own to
make MSVC happy with the Configure probe, hopefully without upsetting
anything else.
I can't actually measure any speedup (or slowdown) from the generated code.
(Yes, Rakudo builds and passes tests)
But the source code (in my opinion) much cleaner this way.
Didn't see a performance change either. I thought we might have one,
then realized I'd set my TEST_JOBS to 8 instead of the usual 6, and that
was to thank. Anyway, things perform no worse, and I agree it's cleaner
and safer.
Thanks!
Jonathan
