On Tue Jul 27 18:58:37 2010, coke wrote:
> On Tue Jun 15 00:11:43 2010, q...@cono.org.ua wrote:
> > perl Configure.pl --gen-parrot failed time to time. Need to do
> > realclean before update.
> >
> > diff --git a/build/gen_parrot.pl b/build/gen_parrot.pl
> > index 63173a3..572f474 100644
> > --- a/build/gen_parrot.pl
> > +++ b/build/gen_parrot.pl
> > @@ -43,12 +43,6 @@ close $REQ;
> >      }
> >  }
> >
> > -print "Checking out Parrot r$reqsvn via svn...\n";
> > -system_or_die(qw(svn checkout -r),  $reqsvn ,
> > qw(https://svn.parrot.org/parrot/trunk parrot));
> > -
> > -chdir('parrot') || die "Can't chdir to 'parrot': $!";
> > -
> > -
> >  ##  If we have a Makefile from a previous build, do a 'make
> realclean'
> >  if (-f 'Makefile') {
> >      my %config = read_parrot_config();
> > @@ -59,6 +53,12 @@ if (-f 'Makefile') {
> >      }
> >  }
> >
> > +print "Checking out Parrot r$reqsvn via svn...\n";
> > +system_or_die(qw(svn checkout -r),  $reqsvn ,
> > qw(https://svn.parrot.org/parrot/trunk parrot));
> > +
> > +chdir('parrot') || die "Can't chdir to 'parrot': $!";
> > +
> > +
> >  print "\nConfiguring Parrot ...\n";
> >  my @config_command = ($^X, 'Configure.pl', @ARGV);
> >  print "@config_command\n";
> >
> >
> 
> +1 on this patch (at least in spirit) from me, but I cannot apply it
> (probably because it was
> inlined in the ticket.) Can you add it as an attachment?
> 
> Thanks!

Wow. Since this last comment, it's been over a year, I have a commit bit 
now, parrot has moved to git, and this patch doesn't apply cleanly 
anymore.

However, digging through the source of rakudo's --gen-parrot step, we 
are now realcleaning if a Makefile is present!

So, applied in spirit. Belatedly.

Thanks!

-- 
Will "Coke" Coleda

Reply via email to