# New Ticket Created by  Allison Randal 
# Please include the string:  [perl #59686]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=59686 >


In fixing the Complex PMC in r31749, I revealed a problem in our 
read-only PMC tests. In t/pmc/ro.t, test 5 gets an error as expected, 
but the error it gets complains that add_p_ic_p doesn't exist (it hasn't 
existed for years, if ever). So, test 5 isn't actually testing anything 
useful.

I'm a bit suspicious about the whole test file now, because it's not 
testing for the actual text of the error message, it's just testing that 
it got *some* error. The cage task is to review the test file and 
improve the error testing, so that if the read-only error is masked by 
some other error, the tests will fail.

One possible direction is to use exception handlers to trap the 
read-only exceptions inside the tests, instead of just relying on the 
exit code.

Allison

Reply via email to