On Fri, Sep 26, 2008 at 07:25:35AM -0700, Chris Davaz wrote:
> Fixed a bug in the doc where the method name and doc where mismatched.

Thanks.

> Fixed a small bug where, even if the user sets the prompt, a default
> prompt '> ' is still printed. Changed it so that a default prompt is
> only printed only if the user had not set a prompt (or set an empty
> prompt).

Unfortunately, the patch causes the prompt to not work properly
when readline is present -- i.e., pressing up-arrow to recover a
previously entered line loses the prompt.  Also, I think it should be
possible for a compiler to set an empty prompt -- this patch makes
that impossible.

I've reworked the patch so that it defaults to '> ' unless a prompt
has been set, in which case it uses that as the prompt.

As far as readline goes, we need to generate our own prompt if
readline isn't present, and allow readline to generate the prompt
if it is.  I've refactored the code to work this way -- 
unfortunately there's a bug (RT #59374) in the pmc2c generation 
for ParrotIO that causes ParrotIO to report that readline is 
available when it really isn't.  So, I'm applying my changes 
to trunk now (r31439), and then when #59374 is fixed we should 
start seeing the prompts in non-readline environments as well.

Thanks for the patch!

Pm

Reply via email to