On Thu Sep 11 23:15:50 2008, cotto wrote: > On Mon Sep 08 22:54:28 2008, [EMAIL PROTECTED] wrote: > > Patrick R. Michaud wrote: > > > > > > Fixing this shouldn't be all that difficult -- in particular, > > > I think that src/pmc/resizablepmcarray.pmc lines 205-206 should > > > be changed from > > > > > > - if (key >= PMC_int_val(SELF)) > > > - SELF.set_integer_native(key+1); > > > > > > to something like > > > > > > + if (key >= PMC_int_val(SELF)) > > > + return PMCNULL; > > > > > > I haven't tested this -- there may be other things that need > > > to change as well. > > > > > > Hope this helps, > > > > > > Pm > > > > > > > It turns out that no further changes were needed to implement this > > behavior. > > The attached patch fixes this (and two incorrect ResizableBooleanArray > > tests). > > With the patch applied, all tests in make test pass. If this is > > what we > > want Parrot to do, I'll apply the patch and add tests to > > Resizable*Array to > > make sure the behavior stays consistent. > > I'm going to give this until next Tuesday for comment, at which point > I'll commit the patch and mark this ticket as resolved.
I got impatient and committed this as r31101. I'm marking this ticket as resolved.
