On Sun, Sep 7, 2008 at 11:06 PM, jerry gay <[EMAIL PROTECTED]> wrote:
> On Tue, Jul 1, 2008 at 7:17 AM, Will Coleda via RT
> <[EMAIL PROTECTED]> wrote:
>> On Thu Jun 26 11:01:00 2008, [EMAIL PROTECTED] wrote:
>>> chromatic wrote:
>>>
>>> > T::H 3 is only a requirement for people who want to type 'make
>>> smolder' (and
>>> > eventually I hope 'make smoke'), so probing for it without bundling
>>> it seems
>>> > eminently sensible to me.
>>>
>>> Agreed. That's what we do with TAP::Harness::Archive.
>>>
>>
>> Based on recent emails to the list, apparently 'make test' in trunk
>> seems to now require T::H 3. (not just for 'make smolder').
>>
>> If we can do without T::H 3 for simple 'make test', that would be nice.
>> If we need it, then we need to have a graceful exit message on make test
>> and not the error we get now.
>>
> T::H 3 has been listed as a required dependency for many test-related
> enhancements, such as parallel testing, aggregated testing, and smoke
> testing. let's make it a requirement, rather than an optional
> dependency. if it proves too burdensome for folks to upgrade, we can
> rollback.
>
>> We also need to add a config probe to test for the version of T:H
>> available, and if it is NOT the minimum version, warn the user that
>> 'make test' will fail to work for them.
>>
>> We also need to see if we can require a specific version in
>> Bundle::Parrot. I'm not sure that's possible. particle?
>>
> yes, it's possible. easy, even. it's done is svn, and i can release to
> cpan on short notice.
>
>> I don't particularly mind requiring T::H 3 even for 'make test', but we
>> definitely need to be careful about it. We should probably declare this
>> in our requirements in the tarball we post to CPAN as well so that don't
>> automatically fail most of our cpan testers.
>>
> that's what Makefile.PL is for. if we require Bundle::Parrot there, we
> can make sure cpan testers have what they need. if we do the same in
> Configure.pl, then we can make sure svn users have what they need,
> too.
>
> something like:
> eval { require Bundle::Parrot };
> if ($@) {
> die "Bundle::Parrot has not been installed, Configure.pl cannot continue.";
> }
>
> that is, if Bundle:: modules get registered with perl. i'm not sure
> that's the case. anyone know better?
> ~jerry
>
I would rather we check for modules here, not the Bundle. Otherwise
sounds reasonable.
--
Will "Coke" Coleda
