On Mon, Aug 25, 2008 at 1:00 PM, <[EMAIL PROTECTED]> wrote:
> Author: moritz
> Date: Mon Aug 25 10:00:25 2008
> New Revision: 30538
>
> Modified:
> trunk/Configure.pl
>
> Log:
> [config] reset MANIFEST.configure.generated before writing to it.
> Patch courtesy by Reini Urban
>
>
> Modified: trunk/Configure.pl
> ==============================================================================
> --- trunk/Configure.pl (original)
> +++ trunk/Configure.pl Mon Aug 25 10:00:25 2008
> @@ -66,6 +66,8 @@
>
> # Log files created by Configure.pl in MANIFEST.configure.generated
> $conf->{active_configuration} = 1;
> +my $generated_log = 'MANIFEST.configure.generated';
> +-e $generated_log && unlink $generated_log;
isn't
unlink $generated_log;
Sufficient here?
For file-related code, I find it preferable to just do something and
check for errors (which we don't care about in this case anyway, and
unlink should just return 0) rather than check to see if I'm allowed
first; (Something else may be twiddling with the filesystem between
the two function calls here)
> # Run the actual steps from Parrot::Configure
> $conf->runsteps or exit(1);
>
--
Will "Coke" Coleda
