On Fri Jun 20 09:01:56 2008, [EMAIL PROTECTED] wrote:
> prove -v t/codingstd/perlcritic.t
> t/codingstd/perlcritic......Undefined subroutine
>
&Perl::Critic::Policy::NamingConventions::ProhibitAmbiguousNames::default_forbidden_words
> called at t/codingstd/perlcritic.t line 142.
> Dubious, test returned 255 (wstat 65280, 0xff00)
> No subtests run
>
> Perl::Critic 1.080 on perl, v5.8.8 built for
> darwin-thread-multi-2level (with 1 registered patch). They check for
> P::C version > 1.03. Not sure if this is related to the use of the
> local lib version of Perl::Critic modules?
> but it may be that default_forbidden_words() doesn't show up until
> 1.084. my 1.080 here has:
> Perl::Critic::Policy::NamingConventions::ProhibitAmbiguousNames::violates()
>
> and violates() uses PPI and ... so, don't know if this is the right
> route but:
>
> Index: t/codingstd/perlcritic.t
>
=========================================================
==========
> --- t/codingstd/perlcritic.t (revision 28576)
> +++ t/codingstd/perlcritic.t (working copy)
> @@ -139,8 +139,12 @@
> );
>
> # Allow some names normally proscribed by PBP.
> - my @ambiguousNames = grep {$_ ne 'abstract'}
> -
>
Perl::Critic::Policy::NamingConventions::ProhibitAmbiguousNames::default_forbidden_words()
;
> + my @ambiguousNames = ();
> + if ( $Perl::Critic::VERSION >= 1.084 ) {
> +# Perl::Critic didn't have default_forbidden until 1.084
> + @ambiguousNames = grep {$_ ne 'abstract'}
> +
>
Perl::Critic::Policy::NamingConventions::ProhibitAmbiguousNames::default_forbidden_words()
> + }
>
> # These policies are not yet passing consistently.
> my %extra_policies = (
>
>
> prove -v t/codingstd/perlcritic.t
> t/codingstd/perlcritic......# Perl::Critic::Bangs not installed: not
> testing for TODO items in code
>
> 1..15
> ok 1 - BuiltinFunctions::ProhibitStringySplit
> ok 2 - CodeLayout::ProhibitDuplicateCoda
> ok 3 - CodeLayout::ProhibitHardTabs
> ok 4 - CodeLayout::ProhibitTrailingWhitespace
> ok 5 - CodeLayout::UseParrotCoda
> ok 6 - InputOutput::ProhibitBarewordFileHandles
> ok 7 - InputOutput::ProhibitTwoArgOpen
> ok 8 - Subroutines::ProhibitExplicitReturnUndef
> ok 9 - Subroutines::ProhibitSubroutinePrototypes
> ok 10 - TestingAndDebugging::MisplacedShebang
> ok 11 - TestingAndDebugging::ProhibitShebangWarningsArg
> ok 12 - TestingAndDebugging::RequirePortableShebang
> ok 13 - TestingAndDebugging::RequireUseStrict
> ok 14 - TestingAndDebugging::RequireUseWarnings
> ok 15 - Variables::ProhibitConditionalDeclarations
> ok
> All tests successful.
> Files=1, Tests=15, 28 wallclock secs ( 0.01 usr 0.00 sys + 26.66 cusr
> 0.41 csys = 27.08 CPU)
> Result: PASS
Merging with RT# 56166
--
Will "Coke" Coleda
