On Tue, Jun 17, 2008 at 10:31 AM, Michael Peters <[EMAIL PROTECTED]> wrote:
> I've got this working pretty well on my checkout (except that the current
> revision, #28476, doesn't build). You can do a "make smolder_test" and have
> the
> results sent to the Smolder server. I talked with chromatic and some others
> about removing some of the old existing smoke stuff, but I'll do that later.
>
> So now the question is how do I send this as a patch. It touches several files
> and adds new ones. Is a simple svn diff good enough? If so, it's attached.
>
excellent! this came together quickly and simply, by the looks of it.
the patch format is fine, especially for a first patch (for more
details of our precise requirements you can read
docs/submissions.pod). one gotcha, you've got 'use Config;' which
pulls info from perl, when you should be using Parrot::Config instead.
it should be an easy switch from $Config{myarchname} to
$PConfig{archname}, if i understand correctly.
as far as i'm concerned, with that simple change this patch can be
applied--and anyone familiar with perl can make that change, it
doesn't have to be michael.
~jerry
