On Wed, May 14, 2008 at 1:09 PM, Geoffrey Broadwell <[EMAIL PROTECTED]> wrote: > On Wed, 2008-05-14 at 07:50 -0700, Will Coleda via RT wrote: >> Nifty! >> >> Minor nits: >> >> - can we use _ instead of - in the filename? >> - can we make the error message more graceful if the disassemble >> executable hasn't been built? >> - it's not always going to be called "disassemble" - you'll need to >> poke into Parrot::Config and pull out the executable suffix and use >> that. (Might be disassemble.exe on windows, for example). > > > I believe the attached patch addresses all of these nits, and also adds > the matching CREDITS diff that I had forgotten to include last time. > > > -'f > >
Excellent. I was about to ask if we could have someone windows test to make sure this works for them... and it would be a lot easier if we had a test (even a very minimal one) to make sure that we were getting the expected output. ^_^ If you can whip that up (on a trivial hello world PIR is fine), great, if not, we need to make sure that we add a ticket to request it; doesn't mean we can't commit this without. Thanks! -- Will "Coke" Coleda
