On Tue, May 13, 2008 at 1:50 AM, via RT Andrew Whitworth <[EMAIL PROTECTED]> wrote:
> src\oo.c(513) : warning C4189: '_class' : local variable is > initialized but not referenced > > The function in question, Parrot_find_vtable_meth, declares the > variable "_class" twice: once at the beginning of the function, and > once inside the for loop. This redeclaration is confusing at best, and > emits a warning because the value for _class is not used inside the > for loop. Looks more problematic to me. I located the change in r26800, described as "Minor cleanups and reformattings": http://svn.perl.org/viewvc/parrot/trunk/src/oo.c?r1=26553&r2=26800 This is the previous version of the code: for (i = 0; i < n; ++i) { for (i = 0; i < n; ++i) { PMC *ns; _class = VTABLE_get_pmc_keyed_int(interp, mro, i); ns = VTABLE_get_namespace(interp, _class); It was not so minor, it changes what _class is used by VTABLE_get_namespace. Looks like this change accidentally inserted a bug. -- Salu2