# New Ticket Created by  Andreas Rottmann 
# Please include the string:  [perl #52588]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=52588 >


Hi!

This patch adds a single file, languages/eclectus/test-wrapper.pl that
contains the code previously found in all of
languages/eclectus/t/*.pl, an replaces these with a single-line 'do'
invocation of test-wrapper.pl.


 MANIFEST                                  |    1 
 languages/eclectus/t/binary_primitives.pl |   38 -----------------------------
 languages/eclectus/t/booleans.pl          |   38 -----------------------------
 languages/eclectus/t/characters.pl        |   38 -----------------------------
 languages/eclectus/t/conditionals.pl      |   38 -----------------------------
 languages/eclectus/t/empty_list.pl        |   38 -----------------------------
 languages/eclectus/t/integers.pl          |   38 -----------------------------
 languages/eclectus/t/learning_scheme.pl   |   38 -----------------------------
 languages/eclectus/t/local_variables.pl   |   38 -----------------------------
 languages/eclectus/t/pair.pl              |   38 -----------------------------
 languages/eclectus/t/procedures.pl        |   38 -----------------------------
 languages/eclectus/t/strings.pl           |   38 -----------------------------
 languages/eclectus/t/unary_primitives.pl  |   38 -----------------------------
 languages/eclectus/t/vectors.pl           |   38 -----------------------------
 languages/eclectus/test-wrapper.pl        |   39 ++++++++++++++++++++++++++++++
 15 files changed, 53 insertions(+), 481 deletions(-)

Refactor the Perl test wrapper into its own file.

From: Andreas Rottmann <[EMAIL PROTECTED]>


---

 MANIFEST                                  |    1 +
 languages/eclectus/t/binary_primitives.pl |   38 +---------------------------
 languages/eclectus/t/booleans.pl          |   38 +---------------------------
 languages/eclectus/t/characters.pl        |   38 +---------------------------
 languages/eclectus/t/conditionals.pl      |   38 +---------------------------
 languages/eclectus/t/empty_list.pl        |   38 +---------------------------
 languages/eclectus/t/integers.pl          |   38 +---------------------------
 languages/eclectus/t/learning_scheme.pl   |   38 +---------------------------
 languages/eclectus/t/local_variables.pl   |   38 +---------------------------
 languages/eclectus/t/pair.pl              |   38 +---------------------------
 languages/eclectus/t/procedures.pl        |   38 +---------------------------
 languages/eclectus/t/strings.pl           |   38 +---------------------------
 languages/eclectus/t/unary_primitives.pl  |   38 +---------------------------
 languages/eclectus/t/vectors.pl           |   38 +---------------------------
 languages/eclectus/test-wrapper.pl        |   39 +++++++++++++++++++++++++++++
 15 files changed, 53 insertions(+), 481 deletions(-)
 create mode 100644 languages/eclectus/test-wrapper.pl


diff --git a/MANIFEST b/MANIFEST
index 50a34d3..0ef7718 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -1318,6 +1318,7 @@ languages/eclectus/src/pmc/eclectusfixnum.pmc               [eclectus]
 languages/eclectus/src/pmc/eclectuspair.pmc                 [eclectus]
 languages/eclectus/src/pmc/eclectusstring.pmc               [eclectus]
 languages/eclectus/src/pmc/eclectusvector.pmc               [eclectus]
+languages/eclectus/test-wrapper.pl                          [eclectus]
 languages/eclectus/t/binary_primitives.pl                   [eclectus]
 languages/eclectus/t/binary_primitives.t                    [eclectus]
 languages/eclectus/t/booleans.pl                            [eclectus]
diff --git a/languages/eclectus/t/binary_primitives.pl b/languages/eclectus/t/binary_primitives.pl
index a758bca..8969ec0 100644
--- a/languages/eclectus/t/binary_primitives.pl
+++ b/languages/eclectus/t/binary_primitives.pl
@@ -1,39 +1,3 @@
 #!/usr/bin/env perl
 
-# Copyright (C) 2007-2008, The Perl Foundation.
-# $Id$
-
-# A wrapper around a Scheme test file
-
-use strict;
-use warnings;
-
-use FindBin;
-use lib "$FindBin::Bin/../../../lib";
-
-use Test::More;
-use Data::Dumper;
-
-( my $t_fn = $FindBin::Script ) =~ s/\.pl$/\.t/;
-
-# 'petite' is Petite Chez Scheme
-# 7.4 is the current version
-my $petite_version = `petite --version 2>&1` || q{};
-my $has_petite = $petite_version =~ m/ \A 7\.4 # exact version
-                                     /xms;
-#diag( Dumper( $petite_version, $has_petite ) );
-
-if ( ! $has_petite ) {
-    plan skip_all => 'petite 7.4 is needed for running this test';
-}
-else {
-    chdir 'eclectus';
-    exec 'petite', '--script', "t/$t_fn";
-}
-
-# Local Variables:
-#   mode: cperl
-#   cperl-indent-level: 4
-#   fill-column: 100
-# End:
-# vim: expandtab shiftwidth=4:
+do 'eclectus/test-wrapper.pl';
diff --git a/languages/eclectus/t/booleans.pl b/languages/eclectus/t/booleans.pl
index a758bca..8969ec0 100644
--- a/languages/eclectus/t/booleans.pl
+++ b/languages/eclectus/t/booleans.pl
@@ -1,39 +1,3 @@
 #!/usr/bin/env perl
 
-# Copyright (C) 2007-2008, The Perl Foundation.
-# $Id$
-
-# A wrapper around a Scheme test file
-
-use strict;
-use warnings;
-
-use FindBin;
-use lib "$FindBin::Bin/../../../lib";
-
-use Test::More;
-use Data::Dumper;
-
-( my $t_fn = $FindBin::Script ) =~ s/\.pl$/\.t/;
-
-# 'petite' is Petite Chez Scheme
-# 7.4 is the current version
-my $petite_version = `petite --version 2>&1` || q{};
-my $has_petite = $petite_version =~ m/ \A 7\.4 # exact version
-                                     /xms;
-#diag( Dumper( $petite_version, $has_petite ) );
-
-if ( ! $has_petite ) {
-    plan skip_all => 'petite 7.4 is needed for running this test';
-}
-else {
-    chdir 'eclectus';
-    exec 'petite', '--script', "t/$t_fn";
-}
-
-# Local Variables:
-#   mode: cperl
-#   cperl-indent-level: 4
-#   fill-column: 100
-# End:
-# vim: expandtab shiftwidth=4:
+do 'eclectus/test-wrapper.pl';
diff --git a/languages/eclectus/t/characters.pl b/languages/eclectus/t/characters.pl
index a758bca..8969ec0 100644
--- a/languages/eclectus/t/characters.pl
+++ b/languages/eclectus/t/characters.pl
@@ -1,39 +1,3 @@
 #!/usr/bin/env perl
 
-# Copyright (C) 2007-2008, The Perl Foundation.
-# $Id$
-
-# A wrapper around a Scheme test file
-
-use strict;
-use warnings;
-
-use FindBin;
-use lib "$FindBin::Bin/../../../lib";
-
-use Test::More;
-use Data::Dumper;
-
-( my $t_fn = $FindBin::Script ) =~ s/\.pl$/\.t/;
-
-# 'petite' is Petite Chez Scheme
-# 7.4 is the current version
-my $petite_version = `petite --version 2>&1` || q{};
-my $has_petite = $petite_version =~ m/ \A 7\.4 # exact version
-                                     /xms;
-#diag( Dumper( $petite_version, $has_petite ) );
-
-if ( ! $has_petite ) {
-    plan skip_all => 'petite 7.4 is needed for running this test';
-}
-else {
-    chdir 'eclectus';
-    exec 'petite', '--script', "t/$t_fn";
-}
-
-# Local Variables:
-#   mode: cperl
-#   cperl-indent-level: 4
-#   fill-column: 100
-# End:
-# vim: expandtab shiftwidth=4:
+do 'eclectus/test-wrapper.pl';
diff --git a/languages/eclectus/t/conditionals.pl b/languages/eclectus/t/conditionals.pl
index a758bca..8969ec0 100644
--- a/languages/eclectus/t/conditionals.pl
+++ b/languages/eclectus/t/conditionals.pl
@@ -1,39 +1,3 @@
 #!/usr/bin/env perl
 
-# Copyright (C) 2007-2008, The Perl Foundation.
-# $Id$
-
-# A wrapper around a Scheme test file
-
-use strict;
-use warnings;
-
-use FindBin;
-use lib "$FindBin::Bin/../../../lib";
-
-use Test::More;
-use Data::Dumper;
-
-( my $t_fn = $FindBin::Script ) =~ s/\.pl$/\.t/;
-
-# 'petite' is Petite Chez Scheme
-# 7.4 is the current version
-my $petite_version = `petite --version 2>&1` || q{};
-my $has_petite = $petite_version =~ m/ \A 7\.4 # exact version
-                                     /xms;
-#diag( Dumper( $petite_version, $has_petite ) );
-
-if ( ! $has_petite ) {
-    plan skip_all => 'petite 7.4 is needed for running this test';
-}
-else {
-    chdir 'eclectus';
-    exec 'petite', '--script', "t/$t_fn";
-}
-
-# Local Variables:
-#   mode: cperl
-#   cperl-indent-level: 4
-#   fill-column: 100
-# End:
-# vim: expandtab shiftwidth=4:
+do 'eclectus/test-wrapper.pl';
diff --git a/languages/eclectus/t/empty_list.pl b/languages/eclectus/t/empty_list.pl
index a758bca..8969ec0 100644
--- a/languages/eclectus/t/empty_list.pl
+++ b/languages/eclectus/t/empty_list.pl
@@ -1,39 +1,3 @@
 #!/usr/bin/env perl
 
-# Copyright (C) 2007-2008, The Perl Foundation.
-# $Id$
-
-# A wrapper around a Scheme test file
-
-use strict;
-use warnings;
-
-use FindBin;
-use lib "$FindBin::Bin/../../../lib";
-
-use Test::More;
-use Data::Dumper;
-
-( my $t_fn = $FindBin::Script ) =~ s/\.pl$/\.t/;
-
-# 'petite' is Petite Chez Scheme
-# 7.4 is the current version
-my $petite_version = `petite --version 2>&1` || q{};
-my $has_petite = $petite_version =~ m/ \A 7\.4 # exact version
-                                     /xms;
-#diag( Dumper( $petite_version, $has_petite ) );
-
-if ( ! $has_petite ) {
-    plan skip_all => 'petite 7.4 is needed for running this test';
-}
-else {
-    chdir 'eclectus';
-    exec 'petite', '--script', "t/$t_fn";
-}
-
-# Local Variables:
-#   mode: cperl
-#   cperl-indent-level: 4
-#   fill-column: 100
-# End:
-# vim: expandtab shiftwidth=4:
+do 'eclectus/test-wrapper.pl';
diff --git a/languages/eclectus/t/integers.pl b/languages/eclectus/t/integers.pl
index a758bca..8969ec0 100644
--- a/languages/eclectus/t/integers.pl
+++ b/languages/eclectus/t/integers.pl
@@ -1,39 +1,3 @@
 #!/usr/bin/env perl
 
-# Copyright (C) 2007-2008, The Perl Foundation.
-# $Id$
-
-# A wrapper around a Scheme test file
-
-use strict;
-use warnings;
-
-use FindBin;
-use lib "$FindBin::Bin/../../../lib";
-
-use Test::More;
-use Data::Dumper;
-
-( my $t_fn = $FindBin::Script ) =~ s/\.pl$/\.t/;
-
-# 'petite' is Petite Chez Scheme
-# 7.4 is the current version
-my $petite_version = `petite --version 2>&1` || q{};
-my $has_petite = $petite_version =~ m/ \A 7\.4 # exact version
-                                     /xms;
-#diag( Dumper( $petite_version, $has_petite ) );
-
-if ( ! $has_petite ) {
-    plan skip_all => 'petite 7.4 is needed for running this test';
-}
-else {
-    chdir 'eclectus';
-    exec 'petite', '--script', "t/$t_fn";
-}
-
-# Local Variables:
-#   mode: cperl
-#   cperl-indent-level: 4
-#   fill-column: 100
-# End:
-# vim: expandtab shiftwidth=4:
+do 'eclectus/test-wrapper.pl';
diff --git a/languages/eclectus/t/learning_scheme.pl b/languages/eclectus/t/learning_scheme.pl
index a758bca..8969ec0 100644
--- a/languages/eclectus/t/learning_scheme.pl
+++ b/languages/eclectus/t/learning_scheme.pl
@@ -1,39 +1,3 @@
 #!/usr/bin/env perl
 
-# Copyright (C) 2007-2008, The Perl Foundation.
-# $Id$
-
-# A wrapper around a Scheme test file
-
-use strict;
-use warnings;
-
-use FindBin;
-use lib "$FindBin::Bin/../../../lib";
-
-use Test::More;
-use Data::Dumper;
-
-( my $t_fn = $FindBin::Script ) =~ s/\.pl$/\.t/;
-
-# 'petite' is Petite Chez Scheme
-# 7.4 is the current version
-my $petite_version = `petite --version 2>&1` || q{};
-my $has_petite = $petite_version =~ m/ \A 7\.4 # exact version
-                                     /xms;
-#diag( Dumper( $petite_version, $has_petite ) );
-
-if ( ! $has_petite ) {
-    plan skip_all => 'petite 7.4 is needed for running this test';
-}
-else {
-    chdir 'eclectus';
-    exec 'petite', '--script', "t/$t_fn";
-}
-
-# Local Variables:
-#   mode: cperl
-#   cperl-indent-level: 4
-#   fill-column: 100
-# End:
-# vim: expandtab shiftwidth=4:
+do 'eclectus/test-wrapper.pl';
diff --git a/languages/eclectus/t/local_variables.pl b/languages/eclectus/t/local_variables.pl
index a758bca..8969ec0 100644
--- a/languages/eclectus/t/local_variables.pl
+++ b/languages/eclectus/t/local_variables.pl
@@ -1,39 +1,3 @@
 #!/usr/bin/env perl
 
-# Copyright (C) 2007-2008, The Perl Foundation.
-# $Id$
-
-# A wrapper around a Scheme test file
-
-use strict;
-use warnings;
-
-use FindBin;
-use lib "$FindBin::Bin/../../../lib";
-
-use Test::More;
-use Data::Dumper;
-
-( my $t_fn = $FindBin::Script ) =~ s/\.pl$/\.t/;
-
-# 'petite' is Petite Chez Scheme
-# 7.4 is the current version
-my $petite_version = `petite --version 2>&1` || q{};
-my $has_petite = $petite_version =~ m/ \A 7\.4 # exact version
-                                     /xms;
-#diag( Dumper( $petite_version, $has_petite ) );
-
-if ( ! $has_petite ) {
-    plan skip_all => 'petite 7.4 is needed for running this test';
-}
-else {
-    chdir 'eclectus';
-    exec 'petite', '--script', "t/$t_fn";
-}
-
-# Local Variables:
-#   mode: cperl
-#   cperl-indent-level: 4
-#   fill-column: 100
-# End:
-# vim: expandtab shiftwidth=4:
+do 'eclectus/test-wrapper.pl';
diff --git a/languages/eclectus/t/pair.pl b/languages/eclectus/t/pair.pl
index a758bca..8969ec0 100644
--- a/languages/eclectus/t/pair.pl
+++ b/languages/eclectus/t/pair.pl
@@ -1,39 +1,3 @@
 #!/usr/bin/env perl
 
-# Copyright (C) 2007-2008, The Perl Foundation.
-# $Id$
-
-# A wrapper around a Scheme test file
-
-use strict;
-use warnings;
-
-use FindBin;
-use lib "$FindBin::Bin/../../../lib";
-
-use Test::More;
-use Data::Dumper;
-
-( my $t_fn = $FindBin::Script ) =~ s/\.pl$/\.t/;
-
-# 'petite' is Petite Chez Scheme
-# 7.4 is the current version
-my $petite_version = `petite --version 2>&1` || q{};
-my $has_petite = $petite_version =~ m/ \A 7\.4 # exact version
-                                     /xms;
-#diag( Dumper( $petite_version, $has_petite ) );
-
-if ( ! $has_petite ) {
-    plan skip_all => 'petite 7.4 is needed for running this test';
-}
-else {
-    chdir 'eclectus';
-    exec 'petite', '--script', "t/$t_fn";
-}
-
-# Local Variables:
-#   mode: cperl
-#   cperl-indent-level: 4
-#   fill-column: 100
-# End:
-# vim: expandtab shiftwidth=4:
+do 'eclectus/test-wrapper.pl';
diff --git a/languages/eclectus/t/procedures.pl b/languages/eclectus/t/procedures.pl
index a758bca..8969ec0 100644
--- a/languages/eclectus/t/procedures.pl
+++ b/languages/eclectus/t/procedures.pl
@@ -1,39 +1,3 @@
 #!/usr/bin/env perl
 
-# Copyright (C) 2007-2008, The Perl Foundation.
-# $Id$
-
-# A wrapper around a Scheme test file
-
-use strict;
-use warnings;
-
-use FindBin;
-use lib "$FindBin::Bin/../../../lib";
-
-use Test::More;
-use Data::Dumper;
-
-( my $t_fn = $FindBin::Script ) =~ s/\.pl$/\.t/;
-
-# 'petite' is Petite Chez Scheme
-# 7.4 is the current version
-my $petite_version = `petite --version 2>&1` || q{};
-my $has_petite = $petite_version =~ m/ \A 7\.4 # exact version
-                                     /xms;
-#diag( Dumper( $petite_version, $has_petite ) );
-
-if ( ! $has_petite ) {
-    plan skip_all => 'petite 7.4 is needed for running this test';
-}
-else {
-    chdir 'eclectus';
-    exec 'petite', '--script', "t/$t_fn";
-}
-
-# Local Variables:
-#   mode: cperl
-#   cperl-indent-level: 4
-#   fill-column: 100
-# End:
-# vim: expandtab shiftwidth=4:
+do 'eclectus/test-wrapper.pl';
diff --git a/languages/eclectus/t/strings.pl b/languages/eclectus/t/strings.pl
index a758bca..8969ec0 100644
--- a/languages/eclectus/t/strings.pl
+++ b/languages/eclectus/t/strings.pl
@@ -1,39 +1,3 @@
 #!/usr/bin/env perl
 
-# Copyright (C) 2007-2008, The Perl Foundation.
-# $Id$
-
-# A wrapper around a Scheme test file
-
-use strict;
-use warnings;
-
-use FindBin;
-use lib "$FindBin::Bin/../../../lib";
-
-use Test::More;
-use Data::Dumper;
-
-( my $t_fn = $FindBin::Script ) =~ s/\.pl$/\.t/;
-
-# 'petite' is Petite Chez Scheme
-# 7.4 is the current version
-my $petite_version = `petite --version 2>&1` || q{};
-my $has_petite = $petite_version =~ m/ \A 7\.4 # exact version
-                                     /xms;
-#diag( Dumper( $petite_version, $has_petite ) );
-
-if ( ! $has_petite ) {
-    plan skip_all => 'petite 7.4 is needed for running this test';
-}
-else {
-    chdir 'eclectus';
-    exec 'petite', '--script', "t/$t_fn";
-}
-
-# Local Variables:
-#   mode: cperl
-#   cperl-indent-level: 4
-#   fill-column: 100
-# End:
-# vim: expandtab shiftwidth=4:
+do 'eclectus/test-wrapper.pl';
diff --git a/languages/eclectus/t/unary_primitives.pl b/languages/eclectus/t/unary_primitives.pl
index a758bca..8969ec0 100644
--- a/languages/eclectus/t/unary_primitives.pl
+++ b/languages/eclectus/t/unary_primitives.pl
@@ -1,39 +1,3 @@
 #!/usr/bin/env perl
 
-# Copyright (C) 2007-2008, The Perl Foundation.
-# $Id$
-
-# A wrapper around a Scheme test file
-
-use strict;
-use warnings;
-
-use FindBin;
-use lib "$FindBin::Bin/../../../lib";
-
-use Test::More;
-use Data::Dumper;
-
-( my $t_fn = $FindBin::Script ) =~ s/\.pl$/\.t/;
-
-# 'petite' is Petite Chez Scheme
-# 7.4 is the current version
-my $petite_version = `petite --version 2>&1` || q{};
-my $has_petite = $petite_version =~ m/ \A 7\.4 # exact version
-                                     /xms;
-#diag( Dumper( $petite_version, $has_petite ) );
-
-if ( ! $has_petite ) {
-    plan skip_all => 'petite 7.4 is needed for running this test';
-}
-else {
-    chdir 'eclectus';
-    exec 'petite', '--script', "t/$t_fn";
-}
-
-# Local Variables:
-#   mode: cperl
-#   cperl-indent-level: 4
-#   fill-column: 100
-# End:
-# vim: expandtab shiftwidth=4:
+do 'eclectus/test-wrapper.pl';
diff --git a/languages/eclectus/t/vectors.pl b/languages/eclectus/t/vectors.pl
index a758bca..8969ec0 100644
--- a/languages/eclectus/t/vectors.pl
+++ b/languages/eclectus/t/vectors.pl
@@ -1,39 +1,3 @@
 #!/usr/bin/env perl
 
-# Copyright (C) 2007-2008, The Perl Foundation.
-# $Id$
-
-# A wrapper around a Scheme test file
-
-use strict;
-use warnings;
-
-use FindBin;
-use lib "$FindBin::Bin/../../../lib";
-
-use Test::More;
-use Data::Dumper;
-
-( my $t_fn = $FindBin::Script ) =~ s/\.pl$/\.t/;
-
-# 'petite' is Petite Chez Scheme
-# 7.4 is the current version
-my $petite_version = `petite --version 2>&1` || q{};
-my $has_petite = $petite_version =~ m/ \A 7\.4 # exact version
-                                     /xms;
-#diag( Dumper( $petite_version, $has_petite ) );
-
-if ( ! $has_petite ) {
-    plan skip_all => 'petite 7.4 is needed for running this test';
-}
-else {
-    chdir 'eclectus';
-    exec 'petite', '--script', "t/$t_fn";
-}
-
-# Local Variables:
-#   mode: cperl
-#   cperl-indent-level: 4
-#   fill-column: 100
-# End:
-# vim: expandtab shiftwidth=4:
+do 'eclectus/test-wrapper.pl';
diff --git a/languages/eclectus/test-wrapper.pl b/languages/eclectus/test-wrapper.pl
new file mode 100644
index 0000000..a758bca
--- /dev/null
+++ b/languages/eclectus/test-wrapper.pl
@@ -0,0 +1,39 @@
+#!/usr/bin/env perl
+
+# Copyright (C) 2007-2008, The Perl Foundation.
+# $Id$
+
+# A wrapper around a Scheme test file
+
+use strict;
+use warnings;
+
+use FindBin;
+use lib "$FindBin::Bin/../../../lib";
+
+use Test::More;
+use Data::Dumper;
+
+( my $t_fn = $FindBin::Script ) =~ s/\.pl$/\.t/;
+
+# 'petite' is Petite Chez Scheme
+# 7.4 is the current version
+my $petite_version = `petite --version 2>&1` || q{};
+my $has_petite = $petite_version =~ m/ \A 7\.4 # exact version
+                                     /xms;
+#diag( Dumper( $petite_version, $has_petite ) );
+
+if ( ! $has_petite ) {
+    plan skip_all => 'petite 7.4 is needed for running this test';
+}
+else {
+    chdir 'eclectus';
+    exec 'petite', '--script', "t/$t_fn";
+}
+
+# Local Variables:
+#   mode: cperl
+#   cperl-indent-level: 4
+#   fill-column: 100
+# End:
+# vim: expandtab shiftwidth=4:
Regards, Rotty
-- 
Andreas Rottmann         | [EMAIL PROTECTED]      | [EMAIL PROTECTED] | [EMAIL 
PROTECTED]
http://rotty.uttx.net    | GnuPG Key: http://rotty.uttx.net/gpg.asc
Fingerprint              | C38A 39C5 16D7 B69F 33A3  6993 22C8 27F7 35A9 92E7
v2sw7MYChw5pr5OFma7u7Lw2m5g/l7Di6e6t5BSb7en6g3/5HZa2Xs6MSr1/2p7 hackerkey.com

A. Because it breaks the logical sequence of discussion
Q. Why is top posting bad?

Reply via email to