[perl #52230] apparently redundant code in pmc creators

[via RT]

# New Ticket Created by  Stephane Payrard 
# Please include the string:  [perl #52230]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=52230 >


the code  pmc.ops :96-97 seems redundant:  pmc_type() is called twice
with the same args  for no apparent reason. And it seems to be a pure
function.
same for another pmc creator.

I recompiled the patched code  and tested rakudo with non adverse effect.

Index: src/ops/pmc.ops
===================================================================
--- src/ops/pmc.ops     (revision 26593)
+++ src/ops/pmc.ops     (working copy)
@@ -93,8 +93,6 @@
         $1 = VTABLE_instantiate(interp, classobj, PMCNULL);
     else {
         INTVAL type = pmc_type(interp, classname);
-        if (!type)
-            type = pmc_type(interp, classname);
         if (type <= 0)
             real_exception(interp, NULL, NO_CLASS,
                 "Class '%Ss' not found", classname);
@@ -111,8 +109,6 @@
         $1 = VTABLE_instantiate(interp, classobj, $3);
     else {
         INTVAL type = pmc_type(interp, classname);
-        if (!type)
-            type = pmc_type(interp, classname);
         if (type <= 0)
             real_exception(interp, NULL, NO_CLASS,
                 "Class '%Ss' not found", classname);



-- 
cognominal stef