On Fri, Mar 21, 2008 at 12:55 PM, Mark Glines via RT <[EMAIL PROTECTED]> wrote: > On Fri, 21 Mar 2008 09:06:59 -0700 > "Andrew Whitworth" (via RT) <[EMAIL PROTECTED]> wrote: > > > # New Ticket Created by "Andrew Whitworth" > > # Please include the string: [perl #51982] > > # in the subject line of all future correspondence about this issue. > > # <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=51982 > > > > > > > > > src/string_primitives.c:Parrot_char_digit_value was producing a > > compile-time warning because the function is supposed to be returning > > a UINTVAL, and is returning -1 on error. I applied a simple typecast > > to make this warning go away. > > As discussed on IRC, I think the correct fix for this is to change the > return type of Parrot_char_digit_value(). This function will return 0 > through 9 given a character in ('0'..'9'), and will return -1 > otherwise. The unsignedness of the return type is just silly. > > Mark >
Okay, i changed the function declaration in src/string_primitives.c and include/Parrot/string_primitives.h. After a search, I couldn't find any other files where the function Parrot_char_digit_value was used, so I don't think anything else needed to be changed. --Andrew Whitworth
