Re: pdd17pmc branch review

[François Perrad]

Will Coleda wrote:
I wanted to call attention to part of today's Parrot Sketch:
<allison> - Otherwise, the PMC branch is ready for language testing,
will plan to merge it back into trunk next weekend.

So, language developers (and others); please grab a copy of
https://svn.perl.org/parrot/branches/pdd17pmc and check out the
languages to see how they fare compared to their counterparts in
trunk.


in r26261 with MinGW32, Lua PMCs seem OK (thank to chromatic).

but WMLScript PMCs don't compile :
many error like
.\wmlsinteger.pmc: In function `Parrot_WmlsInteger_subtract_WmlsString':
.\wmlsinteger.pmc:251: error: void value not ignored as it ought to be

Here, a fragment of wmlsinteger.c :
PMC*
Parrot_WmlsInteger_subtract_WmlsString(PARROT_INTERP, PMC *pmc, PMC 
*value, PMC *dest)
{
#line 250 ".\\wmlsinteger.pmc"

        PMC * trans = Parrot_WmlsString_nci_parseInt(interp, value);
        if (trans->vtable->base_type == dynpmc_WmlsInteger) {
            INTVAL result = VTABLE_get_integer(interp, pmc)
                          - VTABLE_get_integer(interp, trans);
            dest = pmc_new(interp, dynpmc_WmlsInteger);
            VTABLE_set_integer_native(interp, dest, result);
            return dest;
        }
        return pmc_new(interp, dynpmc_WmlsInvalid);
#line 245 ".\\wmlsinteger.c"
}

Now, back to wmlsinteger.pmc :
    PMC* subtract(PMC* value, PMC* dest) {
        ...
MMD_WmlsString: {
            PMC * trans = WmlsString.value.parseInt();
            ...

So, WmlsString.value.parseInt() seems not correctly managed.

Francois.

Nota: WMLScript is a bytecode translator, so the test suite needs a 
WMLScript compiler, you could install it with the command :
        cpan WAP::wmls

Thanks!