On Tuesday 08 January 2008 12:52:28 Allison Randal wrote: > Would be a good PMC cleanup to get in place, if this code can be removed.
> -------- Original Message -------- > Subject: Zombie code? > Date: Wed, 2 Jan 2008 20:43:27 -0000 (UTC) > From: [EMAIL PROTECTED] > To: [EMAIL PROTECTED] > > > While trying to understand Parrot::Vtables.pm, I came across what seems > to be some "zombie" code, possibly left after RT 48877. > > 1. Two references to src/pmc/null.pl, which does not appear to exist. Removed in r24968. > 2. The method "vtbl_embed", which is used only in > parrot/tools/build/vtable_extend.pl That writes > include/parrot/extend_vtable.h and src/extend_vtable.c, neither of which > exist. This is necessary; otherwise you can't call vtable entries on PMCs without knowing the internal details of PMCs. Kept. > 3. Some odd pod in the method around lines 368-372, which makes me think > the expression that spans 367-379 would behave rather oddly if the method > was ever used. Fixed in r24968. -- c
