On Wed Jan 09 06:59:41 2008, [EMAIL PROTECTED] wrote:
> Fixed in r24703
Unfortunately, it breaks one of the tests we've put in place for testing
the build tools (the various .pl files invoked by 'make'). See attached.
The build tools tests are intended to be run after someone has made
changes in modules such as lib/Parrot/Pmc2cUtils/, Ops2cUtils and
Ops2pmutils/. They're set up to be run after Configure.pl has completed
but before make has been invoked. (In fact, they will generate errors
if make has completed.) You can run them with any of the following:
perl Configure.pl --test
perl Configure.pl --test=build
make buildtools_tests (following Configure.pl)
My hunch is that the test file needs a little tweak to match the change
of behavior introduced by your patch. Can you take a look at revising
that test file?
Thank you very much.
kid51
[li11-226:parrot] 503 $ prove -v t/tools/ops2pmutils/08-sort_ops.t
t/tools/ops2pmutils/08-sort_ops....
OK: Parrot top directory located
1..87
ok 1 - use Parrot::Ops2pm::Utils;
ok 2 - Positioned at top-level Parrot directory
ok 3 - changed to temp directory for testing
ok 4 - able to make tempdir/src
ok 5 - able to make tempdir/src
ok 6 - copied .ops file
ok 7 - copied .ops file
ok 8 - copied ops.num file
ok 9 - copied ops.skip file
ok 10 - The object isa Parrot::Ops2pm::Utils
ok 11 - prepare_ops() returned successfully
ok 12 - 'ops' key has been defined
ok 13 - load_op_map_files() completed successfully
ok 14 - ops.num located after renumbering
ok 15 - ops.skip located after renumbering
ok 16 - sort_ops returned successfully
ok 17 - changed back to starting directory after testing
ok 18 - changed to temp directory for testing
ok 19 - able to make tempdir/src
ok 20 - able to make tempdir/src
ok 21 - copied .ops file
ok 22 - copied .ops file
ok 23 - copied .ops file
ok 24 - copied ops.num file
ok 25 - copied ops.skip file
ok 26 - The object isa Parrot::Ops2pm::Utils
ok 27 - prepare_ops() returned successfully
ok 28 - 'ops' key has been defined
ok 29 - load_op_map_files() completed successfully
ok 30 - ops.num located after renumbering
ok 31 - ops.skip located after renumbering
ok 32 - sort_ops returned successfully
ok 33 - changed back to starting directory after testing
ok 34 - changed to temp directory for testing
ok 35 - able to make tempdir/src
ok 36 - able to make tempdir/src
ok 37 - copied .ops file
ok 38 - copied .ops file
ok 39 - copied .ops file
ok 40 - copied ops.num file
ok 41 - copied ops.skip file
ok 42 - copied DEVELOPING file
ok 43 - The object isa Parrot::Ops2pm::Utils
ok 44 - prepare_ops() returned successfully
ok 45 - 'ops' key has been defined
ok 46 - load_op_map_files() completed successfully
ok 47 - ops.num located after renumbering
ok 48 - ops.skip located after renumbering
ok 49 - sort_ops returned successfully
ok 50 - Got expected warning about experimental ops
ok 51 - changed back to starting directory after testing
ok 52 - changed to temp directory for testing
ok 53 - able to make tempdir/src
ok 54 - able to make tempdir/src
ok 55 - copied .ops file
ok 56 - copied .ops file
ok 57 - copied .ops file
ok 58 - copied ops.num file
ok 59 - copied ops.skip file
ok 60 - copied DEVELOPING file
ok 61 - The object isa Parrot::Ops2pm::Utils
ok 62 - prepare_ops() returned successfully
ok 63 - 'ops' key has been defined
ok 64 - load_op_map_files() completed successfully
ok 65 - ops.num located after renumbering
ok 66 - ops.skip located after renumbering
# Looks like you planned 87 tests but only ran 66.
# Looks like your test died just after 66.
dubious
Test returned status 255 (wstat 65280, 0xff00)
DIED. FAILED tests 67-87
Failed 21/87 tests, 75.86% okay
Failed Test Stat Wstat Total Fail List of Failed
-------------------------------------------------------------------------------
t/tools/ops2pmutils/08-sort_ops.t 255 65280 87 42 67-87
Failed 1/1 test scripts. 21/87 subtests failed.
Files=1, Tests=87, 1 wallclock secs ( 0.21 cusr + 0.01 csys = 0.22 CPU)
Failed 1/1 test programs. 21/87 subtests failed.
