On Fri, 14 Dec 2007, James Keenan wrote:

> If at first you don't succeed ...
> 
> The patch attached refactors config/inter/progs.pm for the purpose of  
> increasing its testability.

It passed all tests here.  I haven't had time to review the actual patch, 
but the strategy you describe seems sound.

However, I do want to worry about one thing:  I worry about the growing
time required to run all of these tests.  Just running the t/configure/*
tests now takes 8 minutes on my system, and much of it seems redundant.
For example, files t/configure/107-inter_progs-0[23].t are 131 lines
long each, but only differ in 2 lines of code.  Further, the output of
the two tests is identical except for the file name.  Looking at all 5
inter_progs-0[1-5].t tests, do we really need to test 5 times whether or
not init::defaults has a description?  In fact, looking at the output,
there are apparently 19 separate tests that are run 5 times each.
Is that really necessary?

-- 
    Andy Dougherty              [EMAIL PROTECTED]

Reply via email to