Re: [perl #47980] [Pynie] using invalid attribute syntax...

[Allison Randal]

chromatic wrote:
On Thursday 29 November 2007 20:54:13 Will Coleda wrote:

$ svn diff
Index: src/parser/indent.pir
===================================================================
--- src/parser/indent.pir       (revision 23256)
+++ src/parser/indent.pir       (working copy)
@@ -17,7 +17,7 @@
      .local pmc optable, ws
      optable = get_global '$optable'
      ws = get_global 'ws'
-    setattribute optable, "PGE::OPTable\x0&!ws", ws
+    setattribute optable, "&!ws", ws
      .return ()
  .end

Allison knows better than I do, but that patch looks correct.  I did something 
similar in a lot of code on the pdd15oo branch, way back when.

Aye, it's correct. The old line was using the old syntax to access an 
inherited attribute from a particular parent. The new line works because 
it just directly sets the inherited attribute in the child's data 
storage. If you really needed to access data storage for the parent 
separate from the child (which isn't necessary here), you would use the 
new keyed attribute syntax, where the key specifies the desired parent:

  setattribute optable, ["PGE::OPTable"], "&!ws", ws

Allison