On Wed Nov 07 15:35:16 2007, ptc wrote: > This is a very similar patch to that which I just posted (RT#47245) in > that it moves executable code out of a header. This time > include/atomic/gcc_pcc.h is the header. Unfortunately, since I don't > have access to a ppc machine I can't test this patch, so hopefully > someone can test it on the correct platform and then commit it. What > I *have* been able to test is if the change makes after a 'make > realclean', and this I can confirm. This should also resolve some > compiler warnings > > BTW: this patch and the one I just submitted are directly related to > RT#38929. > > Files affected. > incude/atomic/gcc_pcc.h > config/gen/makefiles/root.in > src/atomic/gcc_pcc.c
Failed on Darwin PPC at about 40% of the way thru 'make'. Note: I only applied this patch; not the other one you posted today. See attached.
Compiling with: xx.c /usr/bin/gcc-3.3 -I./include -fno-common -no-cpp-precomp -pipe -I/usr/local/include -pipe -fno-common -Wno-long-double -DHASATTRIBUTE_CONST -DHASATTRIBUTE_DEPRECATED -DHASATTRIBUTE_FORMAT -DHASATTRIBUTE_MALLOC -DHASATTRIBUTE_NONNULL -DHASATTRIBUTE_NORETURN -DHASATTRIBUTE_PURE -DHASATTRIBUTE_UNUSED -g -W -Wall -Waggregate-return -Wbad-function-cast -Wcast-align -Wcast-qual -Wchar-subscripts -Wcomment -Wdisabled-optimization -Wformat-nonliteral -Wformat-security -Wformat-y2k -Wimplicit -Wimplicit-function-declaration -Wimplicit-int -Wimport -Winline -Wmain -Wmissing-braces -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wno-unused -Wnonnull -Wpacked -Wparentheses -Wpointer-arith -Wreturn-type -Wsequence-point -Wsign-compare -Wstrict-aliasing -Wstrict-prototypes -Wswitch -Wnested-externs -Wundef -Wunknown-pragmas -Wwrite-strings -Wsign-compare -falign-functions=16 -Wdisabled-optimization -Wformat-nonliteral -Wformat-security -Wpacked -Wno-shadow -DHAS_JIT -DPPC -DHAVE_COMPUTED_GOTO -I. -o xx.o -c xx.c src/atomic/gcc_pcc.c In file included from src/atomic/gcc_pcc.c:15: include/parrot/atomic/gcc_pcc.h:26: error: syntax error before "void" include/parrot/atomic/gcc_pcc.h:29: error: syntax error before "long" src/atomic/gcc_pcc.c:18: error: syntax error before "void" src/atomic/gcc_pcc.c:43: error: syntax error before "long" make: *** [src/atomic/gcc_pcc.o] Error 1
