From: Bob Rogers <[EMAIL PROTECTED]>
Date: Mon, 5 Nov 2007 22:05:16 -0500
From: Bob Rogers <[EMAIL PROTECTED]>
Date: Mon, 5 Nov 2007 22:00:10 -0500
Definitely a bug; the attached patch seems to fix it. If you
would kindly confirm that it works, I'll add a proper test case.
(Any ideas where such a test case should go?)
Oops; try this one instead.
Phooey; it seems that the first patch fixes the bug while breaking other
code, and the second one does nothing. Serves me right for posting a
patch without understanding why it works (or seems to).
Does anybody understand why empty strings are not stored here? It
appears that it's been this way since Day 1 . . .
-- Bob
* compilers/imcc/symreg.c:
+ (_mk_symreg): This didn't do _store_symreg of empty strings, which
means they weren't put into the packfile.
Diffs between last version checked in and current workfile(s):
Index: compilers/imcc/symreg.c
===================================================================
--- compilers/imcc/symreg.c (revision 22731)
+++ compilers/imcc/symreg.c (working copy)
@@ -135,8 +135,7 @@
r->color = -1;
r->want_regno = -1;
- if (name[0])
- _store_symreg(hsh,r);
+ _store_symreg(hsh,r);
return r;
}
End of diffs.
