On Monday 29 October 2007 19:54:11 James Keenan via RT wrote:

> The patch attached provides a refactoring of configuration step class
> auto::byteorder along the same lines as other recent refactorings of
> auto::* config classes, i.e., the code handling the C probe is
> refactored into one internal subroutine, while everything that follows
> is refactored into an internal method which is directly addressed in the
> 3 new test files found in the patch.

Are the extra pass() calls at the end to fix the Devel::Cover oddity?  If they 
absolutely have to be there (and I'm personally comfortable with less than 
100% coverage if there are known bugs with D::C), they should probably have 
comments to prevent otherwise well-meaning people like me from refactoring 
code that's not immediately obvious.

-- c

Reply via email to