On 09/10/2007, Leopold Toetsch <[EMAIL PROTECTED]> wrote: > Am Dienstag, 9. Oktober 2007 22:25 schrieb Paul Cochrane: > > In compilers/imcc/optimizer.c:move_ins_out() there is the todo item: > > I really appreciate all the effort to todo-ize these items. But it shouldn't > be done too mechanically.
Thanks for the appreciation :-) I try not to do it too mechanically, but sometimes boredom does take over... It can also be very difficult in many cases to work out exactly what is meant by a given todo item without being familiar with the code. At the very least converting the todo items does provide the opportunity for feedback such as this, and for which I am very grateful! > a few greps in optimizer.c reveal: > > * move_ins_out() is only used in: > * loop_one(), which is used only in > * loop_optimization() and that's turned off as > > if DO_LOOP_OPTIMIZATION > if (loop_optimization(interp, unit)) > return 1; > #endif > ... > > /* buggy - turned off */ > #define DO_LOOP_OPTIMIZATION 0 > > All that mess could just be removed as well, w/o further impact. An oneline > comment could hint to some history of that re svn, but I doubt it'll be worth > the effort ;) So is it ok if I go through and remove these routines? Even if they're buggy don't we want optimisation at some stage, and therefore have these routines fixed? Or will we use a different optimisation strategy in the future? Paul
