On 9/21/07, chromatic <[EMAIL PROTECTED]> wrote:
> On Thursday 20 September 2007 09:38:28 [EMAIL PROTECTED] wrote:
>
> > Modified:
> > trunk/include/parrot/register.h
> > trunk/src/gc/register.c
> >
> > Log:
> > [gc]: add 'struct' to Parrot_Context in func decls/defs
>
> I'm not much of a fan of this because:
>
> > Modified: trunk/src/gc/register.c
> > ===========================================================================
> >=== --- trunk/src/gc/register.c (original)
> > +++ trunk/src/gc/register.c Thu Sep 20 09:38:27 2007
> > @@ -326,8 +326,8 @@
> >
> > PARROT_WARN_UNUSED_RESULT
> > PARROT_CANNOT_RETURN_NULL
> > -Parrot_Context *
> > -Parrot_dup_context(PARROT_INTERP, NOTNULL(const Parrot_Context *old) )
> > +struct Parrot_Context *
> > +Parrot_dup_context(PARROT_INTERP, NOTNULL(const struct Parrot_Context
> > *old) ) {
>
> ... I hate seeing 'struct <type>' in the .c files. Is there a way to move the
> appropriate typedef so that we can remove this cruft from the .c files?
>
i'm no fan of it either, but i had to make these changes so that we
could compile after 'make headerizer'. it's ugly as sin--but it
builds. now i can take a look at ways to make it pretty.
~jerry
