On Sep 3, 2007, at 7:48 AM, Andy Dougherty via RT wrote:

On Fri, 31 Aug 2007, James Keenan via RT wrote:

Andy: If you get a chance, could you do a checkout of the reconfigure branch (https://svn.perl.org/parrot/branches/reconfigure) and run: perl
Configure.pl --test --configure_trace  ?

Here are the results:  (I've skipped all the oks).

Thank you very much for running this report.

The '0: Got wrong verision' failures are due to a wrong @INC somewhere
picking up the wrong version of some library outside the parrot source
tree.


Does that mean you would get these errors if you ran the same command in your sandbox for trunk?


[snip]


t/configure/033_step..............................Can't locate Tie/ Filehandle/Preempt/Stdin.pm in @INC (@INC contains: lib /opt/perl/ lib/5.8.8/sun4-solaris /opt/perl/lib/5.8.8 /opt/perl/lib/site_perl/ 5.8.8/sun4-solaris /opt/perl/lib/site_perl/5.8.8 /opt/perl/lib/ site_perl/5.8.7/sun4-solaris /opt/perl/lib/site_perl/5.8.7 /opt/ perl/lib/site_perl/5.8.6/sun4-solaris /opt/perl/lib/site_perl/ 5.8.6 /opt/perl/lib/site_perl/5.8.5/sun4-solaris /opt/perl/lib/ site_perl/5.8.5 /opt/perl/lib/site_perl/5.8.4/sun4-solaris /opt/ perl/lib/site_perl/5.8.4 /opt/perl/lib/site_perl/5.8.3/sun4- solaris /opt/perl/lib/site_perl/5.8.3 /opt/perl/lib/site_perl/5.8.2/ sun4-solaris /opt/perl/lib/site_perl/5.8.2 /opt/perl/lib/ site_perl .) at t/configure/033_step.t line 16.
BEGIN failed--compilation aborted at t/configure/033_step.t line 16.
# Looks like your test died before it could output anything.
dubious
        Test returned status 255 (wstat 65280, 0xff00)
DIED. FAILED tests 1-32
        Failed 32/32 tests, 0.00% okay



Fixed. This was collateral damage from the corrections I filed in response to your other bug report.


t/configure/036_config_steps......................sh: svn: not found
sh: git: not found
sh: svk: not found
ok

t/configure/107-inter_progs.01....................0: Got wrong version
 at t/configure/107-inter_progs.01.t line 20
Compilation failed in require at t/configure/107-inter_progs.01.t line 20. BEGIN failed--compilation aborted at t/configure/107-inter_progs. 01.t line 20.
# Looks like your test died before it could output anything.
dubious
        Test returned status 255 (wstat 65280, 0xff00)
DIED. FAILED tests 1-24
        Failed 24/24 tests, 0.00% okay
t/configure/107-inter_progs.02....................0: Got wrong version
 at t/configure/107-inter_progs.02.t line 20
Compilation failed in require at t/configure/107-inter_progs.02.t line 20. BEGIN failed--compilation aborted at t/configure/107-inter_progs. 02.t line 20.
# Looks like your test died before it could output anything.
dubious
        Test returned status 255 (wstat 65280, 0xff00)

I've been struggling over these two test files all weekend (albeit in another branch), but I get much farther than this. I'm puzzled by the "Got wrong version"; I've never gotten that.



One other question: Why does the test suite probe over and over again
for svn, svk, and git?  Why can't Configure just look once?


As ptc mentioned, this is in part for historical reasons. We consult the version control system for a number of purposes: determining the Parrot revision number, modifying MANIFEST and MANIFEST.SKIP, etc. That functionality was probably placed into Parrot at different times by different contributors (mostly before I joined) on an "as needed" basis; only a small portion of it was formally tested. I know Paul did a lot of work earlier this year at rationalizing MANIFEST-related scripts.

Your question could be rephrased as, "Should we create a configuration step to check with which VCS you're storing Parrot?" But I think we'd have to weigh the costs and benefits of that step. (And I, for one, would insist that it come with unit tests already created for it ;-) )

kid51

Reply via email to