should Parrot_confess() call abort()? was Re: Thank you so much Josh Hoblitt for the backtracing

[Joshua Hoblitt]

Does anyone object to this patch?

Index: exceptions.c
===================================================================
--- exceptions.c        (revision 20408)
+++ exceptions.c        (working copy)
@@ -771,7 +771,7 @@
 {
     fprintf(stderr, "%s:%u: failed assertion '%s'\n", file, line,
cond);
     Parrot_print_backtrace();
-    exit(EXIT_FAILURE);
+    abort();
 }


-J

--
On Mon, Jul 30, 2007 at 12:29:39PM -1000, Joshua Hoblitt wrote:
> I've just commit some notes on this into docs/debug.pod along with some
> instructions for getting a backtrace with gdb.
> 
> It's worth noting that assert() calls abort() while PARROT_ASSERT
> currently does not so this change is not really semantically equivalent.
> Some people _will want_ a core file as they are particularly useful for
> tracing down intermittent issues in production systems.  Perhaps we need
> a runtime flag to enable/disable core dumps?  I would vote for having
> the dumps by default as many people (well at least me) like to
> control core dumps with ulimit.
> 
> -J
> 
> --
> On Fri, Jul 27, 2007 at 12:42:13AM -0400, Jeff Horwitz wrote:
> > very nice -- i could have used that THIS AFTEROON!  :)
> > 
> > On Thu, 26 Jul 2007, Andy Lester wrote:
> > 
> > >Josh putting in the new backtrace behind my new assertions makes debugging 
> > >assertions SO MUCH EASIER.
> > >
> > >I'm gonna go s/assert/PARROT_ASSERT/ everywhere.
> > >
> > >xoxo,
> > >Andy
> > >
> > >P.S. sample....
> > >
> > ># Received:
> > ># 1..1
> > ># Backtrace - Obtained 16 stack frames (max trace depth is 32).
> > >#   (unknown)
> > >#     Parrot_confess
> > >#       Parrot_make_COW_reference
> > >#         Parrot_String_get_string
> > >#           Parrot_set_s_p
> > >#             (unknown)
> > >#               (unknown)
> > >#                 (unknown)
> > >#                   (unknown)
> > >#                     Parrot_runops_fromc_args
> > >#                       Parrot_runcode
> > >#                         (unknown)
> > >#                           imcc_run
> > >#                             (unknown)
> > >#                               __libc_start_main
> > >#                                 (unknown)
> > ># src/string.c:129: failed assertion 's'
> > >#
> > ># Expected:
> > ># 1..1
> > ># ok 1
> > >#
> > ># Looks like you failed 6 tests of 12.
> > >t/pmc/exporter....dubious
> > >       Test returned status 6 (wstat 1536, 0x600)
> > >
> > >--
> > >Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:petdance
> > >
> > >
> > >
> > >
> > >

pgpn62oisN7l5.pgp
Description: PGP signature