On Tuesday 17 July 2007 21:50:44 [EMAIL PROTECTED] wrote: > Modified: > trunk/src/debug.c > > Log: > Reverse a check on a pointer so that we check for NULL first. Thanks, > Coverity! > > Modified: trunk/src/debug.c > =========================================================================== >=== --- trunk/src/debug.c (original) > +++ trunk/src/debug.c Tue Jul 17 21:50:43 2007 > @@ -344,7 +343,7 @@ > PIO_eprintf(interp, "%li ", line->number); > c = pdb->file->source + line->source_offset; > > - while (*c != '\n' && c) > + while (c && (*c != '\n')) > PIO_eprintf(interp, "%c", *(c++)); > }
That's an improvement, but *can* c actually be NULL here? -- c
