# from Andy Lester
# on Wednesday 27 June 2007 10:09 pm:
>Modified since when?
Create a .critictest file when it succeeds and use that timestamp?
# from chromatic
# on Wednesday 27 June 2007 11:10 pm:
>> What if we have the Perl::Critic checks as Subversion commit hooks?
>> Could email p6i with the results, too. That's what we do at work,
>> and it's annoying, but it's there and it's pretty in-your-face.
>
>If it doesn't hose svk push, where the first of several commits fails
> due to standards violations, I wouldn't mind trying it as an
> experiment.
I would guess a post-commit hook run in the background would be the way
to do it. Besides the timeout issue, complex code preventing a checkin
may be a bad thing because one would need to track-down a server admin
if the gatekeeper script had a bug.
If the tests run quickly enough locally, that will encourage clean
checkins, with the post-commit informing the list of any dirty ones.
--Eric
--
"You can't win. You can't break even. You can't quit."
--Ginsberg's Restatement of the Three Laws of Thermodynamics
---------------------------------------------------
http://scratchcomputing.com
---------------------------------------------------
