On 6/26/07, Paul Cochrane via RT <[EMAIL PROTECTED]> wrote:
On Tue Jun 26 13:35:51 2007, ptc wrote:
> On Tue Jun 26 06:36:50 2007, particle wrote:
> > On 6/26/07, Paul Cochrane via RT <parrotbug-followup <!-- x --> at
> parrotcode.org> wrote:
> > > On Thu Sep 21 14:38:40 2006, particle wrote:
> > > > parrot's source is littered with internal_exception() calls,
the
> bulk
> > > > (all?) of which should be converted to real_exception() calls.
> > > > internal exceptions are uncatchable, and might as well be called
> > > > C<exit>. that's bad, ya dig?
> > > >
> > > > there are plenty of examples of calls to real_exception() so it
> should
> > > > be an easy task for the willing. look in
> > > > F<include/parrot/exceptions.h> for a list of exception
constants.
> > > > convert to E_FooError types where possible.
> > > >
> > > > for an example commit of a modification, C<svn diff -c 14680>,
or
> if
> > > > you don't have svn 1.4.0 yet (why not?) C<svn diff -r
14679:14680>
> > >
> > > As of r19331 there are 190 files affected. The complete list I'm
> > > attaching to this ticket. As I get time, I'm going to attack this
> > > ticket directory by directory.
> > >
> > fab. the safest place to start (least likely to run into cases where
> > we *need* internal_exception) is probably src/pmc.
>
> Attached is a patch for the pmc's. Effectively everything under src/
> pmc but also the relevant perl modules have been changed under lib/
And this patch is for the dynamic pmc's which should really have been
added with the last patch.
looks great, apply away!
~jerry
