Jerry,

let me start with a side point, sorry for the early tangent. why isn't
perlcritic.t using a Getopt:: module--it should be. that'd be a good
cage task, and would make one of my suggestions easier to implement.

As discussed on #parrot, this was already a TODO ticket and Getopt
argument parsing has been implemented as of r19319.

arranging the %policies as a HoH would make it easier to add groupings
as we please. something like:
  my %policies = ( default => { ... }, extra => { ... }, );

have one flag to select which group of policies to run. the special
value 'all' would run all groups. 'default' would be the default. for
example:
  perl t/codingstd/perlcritic.t --group=extra

I've implemented the --group command line argument, but I decided it
was easier to implement separate hashes for 'default' and 'extra'
policies.  It is then simple to create a general hash for specifying
which policies need to be processed in any given run.  See r19332 for
more details.  If you think my implementation can be improved, please
say!  I'm always up to learn more :-)

Thanks for the feedback!  It helps me sharpen my perl skills.

Paul

Reply via email to