I cringe at functions where the behavior is dependent on parms passed in. In the case of Parrot_get_runtime_prefix, if you call it as Parrot_get_runtime_prefix(&str) then str is populated, or if you call Parrot_get_runtime_prefix(NULL) then you get a malloced string.

It should be split into Parrot_get_runtime_prefix_string and Parrot_get_runtime_prefix_cstring.

Anything I'm missing?  Dissent?

xoxo,
Andy

--
Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:petdance




Reply via email to