On Wednesday 13 June 2007 14:46:33 Kevin Tew wrote:

> My patch only fails these tests.
>
> Failed Test          Stat Wstat Total Fail  List of Failed
> ---------------------------------------------------------------------------
>---- t/library/range.t       1   256    78   18  70-78
> t/pmc/parrotobject.t    1   256    11    1  3
>
>
> Chromatic was right,
> vtables should be stored in the namespace in an additional hash indexed
> by vtable_index.

We could store them in a hash indexed by vtable_index and avoid the double 
lookup.  I think the only changes necessary are in 
Parrot_store_sub_in_namespace() and the Namespace PMC (provided that IMCC and 
the packfile reader both set PMC_sub(sub)->vtable_index appropriately before 
storing the sub).

-- c

Reply via email to