chromatic schrieb:
@@ -697,7 +694,7 @@
             $builder->diag("'$cmd' failed with exit code $exit_code")
                 if $exit_code and not $pass;
- unless ( $ENV{POSTMORTEM} ) {
+            if ( ! $ENV{POSTMORTEM} ) {
                 unlink $out_f;
             }

That's an ... odd definition of beautification.  I prefer:

        unlink $out_f unless $ENV{POSTMORTEM};

It's two lines shorter and has several fewer punctuation characters.
That's an habit formed by Perl::Critic:

ControlStructures::ProhibitUnlessBlocks -> replace 'unless (' with 'if ( !' ControlStructures::ProhibitPostfixControls -> use postfix controls only for functions like |die|, |croak|, and |confess|

But as beauty lies in the eye of the beholder, it's just a matter of taste.

Regards,
 Bernhard

Reply via email to