On Jun 1, 2007, at 8:20 PM, Steve Peters wrote:


I can't see any need for such a macro other than for the minor obfuscation that it allows. For most of the Parrot code, I haven't SET_NULL() used, and I haven't used it myself. I'm a bit curious how much it is actually used.

$ ack SET_NULL src | wc -l
23

It looks like it's mostly for SET_NULL_P where they intent is to cast NULL to a given type, as in:

src/inter_create.c:198: SET_NULL_P(CONTEXT(interp->ctx)- >current_object, PMC*);

But Lord knows there are enough cases where we're NOT using those macros and not getting problems.

I'm gonna yank 'em.

xoxo,
Andy


--
Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:petdance




Reply via email to