Am Montag, 28. Mai 2007 01:45 schrieb pancake: > I have been reading the source code of he virtual machine a bit and found > some confusing things and other stuff that imho should change. > > Most of this patches are merely stupid, so they are easy to fix and will > reflect on a clenaer and reduced source code. > > I will probably submit other similar mails, because some of these patches > can require a little discussion. > > Here it is my NOTES file: > > exec.c:37 -- confusing comment. > remove it and use a enum to clarify
While using an enum is certainly a goot thing(tm) removing the comment is really a bad idea. The functionality of the exec subsystem isn't that trivial > src/exec.c:217 -- strange hack, looks ugly > #if defined(EXEC_A_OUT) || defined(EXEC_COFF) > /* for the trailing "_" */ > obj->symbol_list_size++; > #endif > Can this code be removed? What are you smokin'? Sorry. You are asking to remove code needed for correct functionality just because it "looks ugly". Please rethink your code change proposals. Thx. (No it can't be removed). leo
