On Tuesday 15 May 2007 11:22:25 jerry gay wrote: > just below this code in that file, there's an #if 0 block i'm not > responsible for. there vars were used only in that block. i wrapped > them in #if 0 simply to remove the warning, while keeping the intent > of the code the same. > > i agree that #if 0 is bad practice in general. i didn't have tuits at > the time to perform a code review on this block--i just corrected an > oversight by the original coder. i've forwarded this to rt, so > somebody can clean up this code properly.
That's very reasonable. I think we've found our FOTW. -- c
