On Tue, 27 Mar 2007, Steve Peters via RT wrote:
> On Tue Mar 27 10:54:17 2007, doughera wrote:
> > Instead of sprinking (opcode_t *) casts everywhere, wouldn't it be better
> > to declare the invoke() function as returning an (opcode_t *) ?
> > Similarly for most of the other bits you patched. Wouldn't it make more
> > sense in the long run to change the functions to say they return what they
> > actually return?
> >
>
> I'll have to look into some of these a little more closely as I go
> through. I should probably go through and refactor as I work on this
> cleanup. I probably should reject this particular patch and look for
> some lower level cleanups that might make this whole process much
> easier, such as what you two have pointed out.
I think you'll find a lot of lower-level cleanups are in order. Leo
tended to assume all pointers could equally well point anywhere, and often
ignored alignment issues. He often declared stuff (void *) when it really
should have been something more specific. Unfortunately, he also tended
to reject patches to try to clean it up. I wish you better luck.
--
Andy Dougherty [EMAIL PROTECTED]
