Alek Storm wrote:
# New Ticket Created by "Alek Storm"
# Please include the string: [perl #41619]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=41619 >
This patch adds the add_attr, rem_attr, and rem_attr_str vtable
methods. These will come in handy for Ruby's metaclasses or
Smalltalk's class objects. The only PMC currently affected by this is
ParrotClass, and the rem_attr and rem_attr_str methods are still
unimplemented.
Files affected:
src/ops/object.ops
src/pmc/parrotclass.pmc
vtable.tbl
FWIW, I applied this patch in the buildtools branch and ran 'make
buildtools_tests'. Everything passed.
[bt] 518 $ patch -p0 < add_attr.patch
patching file src/ops/object.ops
patching file src/pmc/parrotclass.pmc
patching file vtable.tbl
[bt] 519 $ make buildtools_tests
/usr/local/bin/perl t/harness t/tools/pmc2cutils/00-qualify.t
t/tools/pmc2cutils/01-pmc2cutils.t t/tools/pmc2cutils/02-find_file.t
t/tools/pmc2cutils/03-dump_vtable.t t/tools/pmc2cutils/04-dump_pmc.t
t/tools/pmc2cutils/05-gen_c.t t/tools/pmc2cutils/06-print_tree.t
t/tools/pmc2cutils/07-open_file.t t/tools/ops2pmutils/00-qualify.t
t/tools/ops2pmutils/01-ops2pmutils.t t/tools/ops2pmutils/02-usage.t
t/tools/ops2pmutils/03-new.t t/tools/ops2pmutils/04-prepare_ops.t
t/tools/ops2pmutils/05-renum_op_map_file.t
t/tools/ops2pmutils/06-load_op_map_files.t
t/tools/ops2pmutils/07-no_ops_skip.t t/tools/ops2pmutils/08-sort_ops.t
t/tools/ops2pmutils/09-prepare_real_ops.t
t/tools/ops2pmutils/10-print_module.t t/tools/ops2pmutils/11-print_h.t
t/tools/ops2cutils/01-new.t t/tools/ops2cutils/02-usage.t
t/tools/ops2cutils/03-print_c_header_file.t
t/tools/ops2cutils/04-print_c_source_top.t
t/tools/ops2cutils/05-print_c_source_bottom.t
t/tools/ops2cutils/06-dynamic.t t/tools/ops2cutils/07-make_incdir.t
t/tools/ops2cutils/08-nolines.t t/tools/ops2cutils/09-dynamic_nolines.t
t/tools/pmc2cutils/00-qualify..................ok
t/tools/pmc2cutils/01-pmc2cutils...............ok
t/tools/pmc2cutils/02-find_file................ok
t/tools/pmc2cutils/03-dump_vtable..............ok
t/tools/pmc2cutils/04-dump_pmc.................ok
t/tools/pmc2cutils/05-gen_c....................ok
t/tools/pmc2cutils/06-print_tree...............ok
t/tools/pmc2cutils/07-open_file................ok
t/tools/ops2pmutils/00-qualify.................ok
t/tools/ops2pmutils/01-ops2pmutils.............ok
t/tools/ops2pmutils/02-usage...................ok
t/tools/ops2pmutils/03-new.....................ok
t/tools/ops2pmutils/04-prepare_ops.............ok
t/tools/ops2pmutils/05-renum_op_map_file.......ok
t/tools/ops2pmutils/06-load_op_map_files.......ok
t/tools/ops2pmutils/07-no_ops_skip.............ok
t/tools/ops2pmutils/08-sort_ops................ok
t/tools/ops2pmutils/09-prepare_real_ops........ok
t/tools/ops2pmutils/10-print_module............ok
t/tools/ops2pmutils/11-print_h.................ok
t/tools/ops2cutils/01-new......................ok
t/tools/ops2cutils/02-usage....................ok
t/tools/ops2cutils/03-print_c_header_file......ok
t/tools/ops2cutils/04-print_c_source_top.......ok
t/tools/ops2cutils/05-print_c_source_bottom....ok
t/tools/ops2cutils/06-dynamic..................ok
t/tools/ops2cutils/07-make_incdir..............ok
t/tools/ops2cutils/08-nolines..................ok
t/tools/ops2cutils/09-dynamic_nolines..........ok
All tests successful.
Files=29, Tests=1023, 65 wallclock secs (43.84 cusr + 7.41 csys = 51.25
CPU)
[bt] 520 $
