On 12/02/07, jerry gay <[EMAIL PROTECTED]> wrote:
On 2/11/07, via RT Paul Cochrane <[EMAIL PROTECTED]> wrote: > # New Ticket Created by Paul Cochrane > # Please include the string: [perl #41485] > # in the subject line of all future correspondence about this issue. > # <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=41485 > > > > chromatic asked me recently whether or not a subversion property > exists for line endings to help keep text files consistent within the > repository. It turns out there is, namely the svn:eol-style property. > This should be set to "LF" so that one has Unix-style end-of-line > characters. I have added a test for this into > t/codingstd/line_endings.t but before I commit it, I thought I'd check > if having all text files have this property set was appropriate > (especially for Windows users). > > If noone complains then I'll commit the change, and close this ticket. > svn:eol-style should be set to 'native', so it'll save files with the line ending the platform expects. the only exceptions i'm aware of are examples using file io. as the tests are currently designed, these require svn:eol-style=LF (see t/examples/streams.t for more.)
I'd thought about using 'native' but the line endings test explicitly looks for DOS endings with a view to removing them, so why not let svn handle this task? Do users on Windows have major problems editing the files because they're all (mostly) UNIX line endings? Should we change the coding standard test to look just for text files with the eol-style set to native, and not worry about DOS/UNIX etc line endings?
if you want to make sure this test is platform-friendly before committing, feel free to attach the patch to this ticket, and i'll run it on windows.
I've attached the patch to this email, let me know how you go. Paul
line_endings.patch
Description: Binary data
