# New Ticket Created by James Keenan
# Please include the string: [perl #41329]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=41329 >
FILES AFFECTED:
t/tools/pmc2cutils/00-qualify.t
t/tools/pmc2cutils/01-pmc2cutils.t
t/tools/pmc2cutils/02-find_file.t
t/tools/pmc2cutils/03-dump_vtable.t
t/tools/pmc2cutils/04-dump_pmc.t
t/tools/pmc2cutils/05-gen_c.t
t/tools/pmc2cutils/06-print_tree.t
t/tools/pmc2cutils/07-open_file.t
HOW BUG IS MANIFEST:
After running Configure.pl, but before running make, call either:
make buildtools_tests
or
prove -v t/tools/pmc2cutils/*.t
You will get the output in the attachment.
ANALYSIS:
In r16751, certain code was repositioned to conform with Parrot
coding standards. However, when repositioning code in test files,
one is well advised to re-run the tests to see if they all still
pass. This apparently was not done. If they had been done, it would
have been evident that calling 'use strict' before the BEGIN block --
with no other changes -- was ill advised.
I will try to repair the damage consistent with the coding standards.
kid51
t/tools/pmc2cutils/00-qualify........1..9
ok 1 - use Parrot::Pmc2c::Utils;
ok 2 - Makefile located
ok 3 - myconfig located
ok 4 - lib/Parrot/PMC.pm located
ok 5 - only 2 file suffixes in src/pmc
ok 6 - .num suffix correctly located
ok 7 - .pmc suffix correctly located
ok 8 -
#
The files in this directory test the publicly callable methods of
# Parrot::Pmc2c::Utils. By doing so, they test the functionality
# of the pmc2c.pl utility.
#
Since pmc2c.pl is invoked many times during 'make', tests of its
# functionality can give meaningful results only if you run them
# when your file system under the top-level Parrot directory is in
# a 'pre-make' state, i.e., you have run 'perl Configure.pl' but
# have *not* yet run 'make'. These tests should pass if run at
# that point in the build process, but some will necessarily fail
# if 'make' has already been executed. Hence, they should not be
# included in the set of tests run by 'make test'.
#
In short, these are tests of Parrot::Pmc2c::Utils but are *not*
# tests of Parrot itself.
#
ok 9 - Completed all tests in t/tools/pmc2cutils/00-qualify.t
ok
t/tools/pmc2cutils/01-pmc2cutils.....Global symbol "$topdir" requires explicit
package name at t/tools/pmc2cutils/01-pmc2cutils.t line 13.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/01-pmc2cutils.t line 14.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/01-pmc2cutils.t line 17.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/01-pmc2cutils.t line 19.
BEGIN not safe after errors--compilation aborted at
t/tools/pmc2cutils/01-pmc2cutils.t line 20.
dubious
Test returned status 255 (wstat 65280, 0xff00)
t/tools/pmc2cutils/02-find_file......Global symbol "$topdir" requires explicit
package name at t/tools/pmc2cutils/02-find_file.t line 13.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/02-find_file.t line 14.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/02-find_file.t line 17.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/02-find_file.t line 19.
BEGIN not safe after errors--compilation aborted at
t/tools/pmc2cutils/02-find_file.t line 20.
dubious
Test returned status 255 (wstat 65280, 0xff00)
t/tools/pmc2cutils/03-dump_vtable....Global symbol "$topdir" requires explicit
package name at t/tools/pmc2cutils/03-dump_vtable.t line 13.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/03-dump_vtable.t line 14.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/03-dump_vtable.t line 17.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/03-dump_vtable.t line 19.
BEGIN not safe after errors--compilation aborted at
t/tools/pmc2cutils/03-dump_vtable.t line 20.
dubious
Test returned status 255 (wstat 65280, 0xff00)
t/tools/pmc2cutils/04-dump_pmc.......Global symbol "$topdir" requires explicit
package name at t/tools/pmc2cutils/04-dump_pmc.t line 13.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/04-dump_pmc.t line 14.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/04-dump_pmc.t line 17.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/04-dump_pmc.t line 19.
BEGIN not safe after errors--compilation aborted at
t/tools/pmc2cutils/04-dump_pmc.t line 20.
dubious
Test returned status 255 (wstat 65280, 0xff00)
t/tools/pmc2cutils/05-gen_c..........Global symbol "$topdir" requires explicit
package name at t/tools/pmc2cutils/05-gen_c.t line 13.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/05-gen_c.t line 14.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/05-gen_c.t line 17.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/05-gen_c.t line 19.
BEGIN not safe after errors--compilation aborted at
t/tools/pmc2cutils/05-gen_c.t line 20.
dubious
Test returned status 255 (wstat 65280, 0xff00)
t/tools/pmc2cutils/06-print_tree.....Global symbol "$topdir" requires explicit
package name at t/tools/pmc2cutils/06-print_tree.t line 13.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/06-print_tree.t line 14.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/06-print_tree.t line 17.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/06-print_tree.t line 19.
BEGIN not safe after errors--compilation aborted at
t/tools/pmc2cutils/06-print_tree.t line 20.
dubious
Test returned status 255 (wstat 65280, 0xff00)
t/tools/pmc2cutils/07-open_file......Global symbol "$topdir" requires explicit
package name at t/tools/pmc2cutils/07-open_file.t line 13.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/07-open_file.t line 14.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/07-open_file.t line 17.
Global symbol "$topdir" requires explicit package name at
t/tools/pmc2cutils/07-open_file.t line 19.
BEGIN not safe after errors--compilation aborted at
t/tools/pmc2cutils/07-open_file.t line 20.
dubious
Test returned status 255 (wstat 65280, 0xff00)
Failed Test Stat Wstat Total Fail List of Failed
-------------------------------------------------------------------------------
t/tools/pmc2cutils/01-pmc2cutils.t 255 65280 ?? ?? ??
t/tools/pmc2cutils/02-find_file.t 255 65280 ?? ?? ??
t/tools/pmc2cutils/03-dump_vtable.t 255 65280 ?? ?? ??
t/tools/pmc2cutils/04-dump_pmc.t 255 65280 ?? ?? ??
t/tools/pmc2cutils/05-gen_c.t 255 65280 ?? ?? ??
t/tools/pmc2cutils/06-print_tree.t 255 65280 ?? ?? ??
t/tools/pmc2cutils/07-open_file.t 255 65280 ?? ?? ??
Failed 7/8 test scripts. 0/9 subtests failed.
Files=8, Tests=9, 2 wallclock secs ( 0.56 cusr + 0.21 csys = 0.77 CPU)
Failed 7/8 test programs. 0/9 subtests failed.
