On Sun, Jan 07, 2007 at 03:34:41PM +0800, Lee Duhem wrote: > I think we need some diff-like facility for string in Test::More > (or somewhere else appropriate), these options of diff for files > will be wanted: > > -E --ignore-tab-expansion Ignore changes due to tab expansion. > -b --ignore-space-change Ignore changes in the amount of white space. > -w --ignore-all-space Ignore all white space. > -B --ignore-blank-lines Ignore changes whose lines are all blank. > --strip-trailing-cr Strip trailing carriage return on input. > > > A few days ago, test t/examples/past.t fails because particle's > whitespace clean up on it, some tailing spaces in expect output > have been removed. If we have this facility and use it, this test > will be passed perfectly after particle's whitespace cleanup.
Shouldn't that have failed tests before it was checked in? I'm not convinced that allowing slop in expected output is a good idea. It introduces (more) complexity into the tests, which increases the chance for false positives (errors in the tests reporting themselves as failures, distracting developers) and false negatives (tests not spotting real errors) Nicholas Clark
