On Oct 25, 2006, at 1:24 PM, Jerry Gay (via RT) wrote:

modify perl coding standard test format to match the c tests--one test
per standard, rather than one test per file.

coding standard tests are designed to test maintainability, not
functionality. testing parrot functionality is much more important
than testing maintainability--just look at perl 5 :-)

inflating test numbers (and percentages) by adding a zillion coding
standards tests leads to false perception of test coverage. i'd like
very much to avoid this situation.
~jerry

Jerry,

I fully understand your reasoning, but this is going to slow down the tests. Perl::Critic's overhead comes primarily from parsing each source file, not from checking the standards, so Test::Perl::Critic is oriented to work per-file. Your suggested change goes across the grain for Perl::Critic.

Certainly the perlcritic.t can be changed to have just one test -- all files pass all standards, or not -- without a performance penalty, but perhaps that might be too much in the other direction?

Chris

Reply via email to