On Oct 17, 2006, at 4:25 PM, Jerry Gay via RT wrote:
On Tue Oct 17 07:33:02 2006, [EMAIL PROTECTED] wrote:
Well, the verdict defnitely seems to be that trailing space and tab
characters are annoyances that should go away :-) This patch adds a
new test (in place of the curly-space test I posted earlier) which
searches for superfluous trailing spaces in source files.
Comments definitely welcome!
this is too noisy as ~700 tests. please convert it to one test,
like the
other coding standard tests.
t/codingstd/perlcritic.pl at least, has a test per file.
also, it should apply to perl files, as well. in fact, it should
probably apply to most files in MANIFEST and MANIFEST.skip, except
for a
few where the spaces are required (like some test data files.)
however,
i'd accept this patch if it were extended only to cover the perl
files.
This is covered by perlcritic already, and if not, should be. I'm
happy to keep this targeted at the c-only files.
These tests already take too long to run, no need to test everything 2x.
thanks for your hard work!
~jerry
--
Will "Coke" Coleda
[EMAIL PROTECTED]
