Am Dienstag, 17. Oktober 2006 22:33 schrieb Kevin Tew: > While exploring Parrot internals I started cleaning up some code. > I'll post patches to the list, but here are some things that are not > defined by the coding standards, but of which I'm a fan. > So the question is are they acceptable in the parrot code base. > > 1) *s should go right next to the type in function declarations and > definitions > > /* incorrect */ > do_thaw(Parrot_Interp interpreter, PMC * pmc, visit_info *info) > /* correct */ > do_thaw(Parrot_Interp interpreter, PMC* pmc, visit_info* info)
Both look wrong to me, my POV is: do_thaw(Interp *interpreter, PMC *pmc, visit_info *info) a) Parrot_Interp was removed for some reason long time ago in almost all of the code (it's usage ought to be in embed land). Please lookup p6i history. b) Re PMC* a vs. PMC *a: the former might make one think of PMC* is declaring some pointers: PMC* a, b; # oops wrong b isn't a pointer at all PMC *a, *b; # all fine > 2) All structs should be typedefed No. Commonly used structs might be typedefed, but that should never be enforced. > 3) Single line if and elses are acceptable Nevva. > 4) c89 allows declaration and initialization on the same line right? > INTVAL counter = 0; of course. > Kevin leo
