Jerry,

1) the patch leaves trailing spaces after the closing brackets (this
isn't a coding standard (yet) but is a pet peeve of mine. if it were
this alone, i'd modify the patch myself and apply.
I can add a test for this to t/codingstd/cuddled_else.t if you want.

2) many of the source files you modified didn't show up in the output
from the test. compare the list of files you modified to the list of
failed files (here's my run from r14895):
<snip>
can you repeat this result?
Yes, I got exacly the same output from r14895.  Actually, this patch
was already applied by Bernhard in r14870, which explains why the
effected files list looks different.  The cuddled else patch I most
recently sent in ([perl #40507]) applied only to pmc files and is
(indirectly) a result of the patch of t/codingstd/cuddled_else.t in
r14985.

Regards,

Paul

Reply via email to