On Sat, Aug 12, 2006 at 08:14:52PM -0400, Charles Reiss wrote: > I wrote: > >The read-only variant generation currently does not handle NCI methods > >at all. There are number of implementation options; the best I can > >think of is to override findmethod (in the read-only type) to check > >for a property on the found method PMC that would indicates it writes > >(or vice-versa). > > This is done (w/ s/findmethod/find_method/ of course), returning PMCNULL > instead of a method that would write. (This prevents it from being called, > but doesn't yield helpful errors.)
Yow, done already! Excellent. (Shoulda read the followup first.) > >It also does not allow .pmc files to overide the default idea of > >whether a vtable method is read-only. > > This remains unresolved though I'm not certain it should be allowed. > The hard part of doing it correctly is handling inheritance. It's an interface guarantee, and as such I think it's OK that it can't be overridden in a derived class. Agree? > >A bigger issue for automatic read-only variant generation is that MMD > >methods currently don't do any read-onlyness detection. (Sorry!) > > This is now fixed. Yow^2! Nice work. -- Chip Salzenberg <[EMAIL PROTECTED]>
