Hi,
Thomas Klausner schrieb:
On Tue, Jul 18, 2006 at 12:27:30PM +0200, Steffen Mueller wrote:
we had a discussion about distributions with broken versions of
Module::Install. Using Module::CPANTS::Kwalitee::* as models I wrote a
simple plugin that calculates a Kwalitee metric "uses_broken_installer".
Cool!
Maybe we should call it 'uses_broken_bundled_installer' or
'uses_broken_module_install'?
I don't think so. If a bug in certain Module::Build versions was to be
discovered, the resulting broken Makefile.PL's or Build.PL's could also
be included in this metric. So neither "bundled" nor "module_install"
applies in that case.
The BrokenInstaller.pm file is attached. It's a straightforward adaption
of what the other metric plugins do.
I only took a short glance (/me is @work ATM), but it looks ok. I'll
take a closer look in the evening.
Since http://steffen-mueller.net/mi_old.html is generated using very
similar heuristics, the part in analyse() should be fine. I just took
::Files.pm and replaced the obvious pieces with my code.
domm: What do you think? Is this a good metric?
I think it's a good metric, but maybe Module::Install-supports will
disagree :-)
I doubt that. It's not aimed at Module::Install or anything. If anybody
knows about deficiencies in older M::I releases, it's the
Module::Install maintainers!
We could also add checks for problems in Makefile.PL/Build.PL...
Exactly. That's why I'd like to keep this from being Module::Install
specific. Separate metric seem overkill.
If so, would you like to
include the plugin in the distribution or do you want me to upload a
separate distribution?
I'd rather include it in MCA.
Perfect.
Steffen
