在 2006/7/18 上午 6:21 時，Audrey Tang 寫到：
在 2006/7/18 上午 5:24 時，Audrey Tang 寫到：在 2006/7/18 上午 4:38 時，Allison Randal 寫到：This is not a maintainable build solution. Revert and come back when you have one.Please clarify: What, exactly, is not maintainable? The presence of a .diff file, or the fact that it needs to be applied manually?If the latter, an extra line of Makefile rule suffices. If the former, a bison post-processor wrapper is needed.Assuming both were considered unmaintainable, fixed them, and committed again as r13348.I'd be willing to revert r13348 again if you find anything wrong with it, but a more specific response would be appreciated.
The obvious wrong thing with it is that it doesn't come with a check for flex >= 2.5.33. Joshua on #parrot said he'll fix that in the morning.
Another obvious point was the resilience of the post processor against bison outputs. Fortunately, it appears that with bison >= 2.2, multiple %lex-param is supported (though they need to be declared in separate lines, unlike %parse-param), and multiple %parse- param is also made available to all functions including the destructor. Hence if we can bump the version dependency of bison too, then this can work without source-level patching at all (committed as .
So, is this maintainer-side dependency (bison 2.2+, flex 2.5.33+; does not affect the user) a reasonable cost for IMCC reentrancy?
Thanks, Audrey
PGP.sig
Description: This is a digitally signed message part
